Skip to content

python3Packages.warp-lang: 1.9.0 -> 1.9.1, fix build#456471

Merged
ConnorBaker merged 4 commits intoNixOS:masterfrom
yzx9:warp-lang-1-9-1
Nov 3, 2025
Merged

python3Packages.warp-lang: 1.9.0 -> 1.9.1, fix build#456471
ConnorBaker merged 4 commits intoNixOS:masterfrom
yzx9:warp-lang-1-9-1

Conversation

@yzx9
Copy link
Contributor

@yzx9 yzx9 commented Oct 28, 2025 •
edited
Loading

  • fix build (switching to LLVM 19)
  • dynamic linking clang / LLVM (~200MB -> 686KB)
  • 1.9.0 -> 1.9.1

Hydra: https://hydra.nixos.org/build/310728547

ZHF: #457852

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 6.topic: python Python is a high-level, general-purpose programming language. labels Oct 28, 2025
@yzx9 yzx9 force-pushed the warp-lang-1-9-1 branch 2 times, most recently from 05f5e1e to 89c1fe3 Compare October 29, 2025 08:24
@yzx9 yzx9 added the 6.topic: cuda Parallel computing platform and API label Oct 29, 2025
@nixpkgs-ci nixpkgs-ci bot removed the 6.topic: cuda Parallel computing platform and API label Oct 29, 2025
@yzx9 yzx9 marked this pull request as ready for review October 29, 2025 09:07
@nix-owners nix-owners bot requested a review from natsukium October 29, 2025 09:08
@yzx9
Copy link
Contributor Author

yzx9 commented Oct 29, 2025

@ConnorBaker Hi! Could you please take a look at why I’m running into this error?

> NIXPKGS_ALLOW_UNFREE=1 nix build --impure .#python3Packages.warp-lang.passthru.tests.cuda.cudaOnly

error: Package ‘cuda12.8-cuda_nvcc-12.8.93’ in /nix/store/r5pa0cg7psiqm1whgwwwswzspsg82zcl-source/pkgs/development/cuda-modules/packages/cuda_nvcc.nix:174 is marked as broken, refusing to evaluate.

I suspect it might be caused by the following code, but I’m not sure why pkgsLLVM is being used on an x86_64-linux machine:

nixpkgs/pkgs/development/cuda-modules/packages/cuda_nvcc.nix

Lines 156 to 171 in 038f97c

brokenAssertions = [
# TODO(@connorbaker): Build fails on x86 when using pkgsLLVM.
# .../include/crt/host_defines.h:67:2:
# error: "libc++ is not supported on x86 system"
#
# 67 | #error "libc++ is not supported on x86 system"
# | ^
#
# 1 error generated.
#
# # --error 0x1 --
{
message = "cannot use libc++ on x86_64-linux";
assertion = backendStdenv.hostNixSystem == "x86_64-linux" -> backendStdenv.cc.libcxx == null;
}
];

@ConnorBaker
Copy link
Contributor

ConnorBaker commented Oct 29, 2025 •
edited
Loading

Use --show-trace --trace-verbose since that will print the failed assertions.

EDIT: make sure you’re setting config.cudaSupport as well when you instantiate Nixpkgs

@yzx9
Copy link
Contributor Author

yzx9 commented Oct 30, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 456471
Commit: bde133813053445a0485231aaf61354f3b18a6be

x86_64-linux

✅ 4 packages built:
  • python312Packages.warp-lang
  • python312Packages.warp-lang.dist
  • python313Packages.warp-lang
  • python313Packages.warp-lang.dist

aarch64-darwin

✅ 4 packages built:
  • python312Packages.warp-lang
  • python312Packages.warp-lang.dist
  • python313Packages.warp-lang
  • python313Packages.warp-lang.dist

@yzx9
Copy link
Contributor Author

yzx9 commented Oct 30, 2025 •
edited
Loading

@ConnorBaker Thanks! You’re right. It was caused by the fact that I hadn’t enabled cudaSupport yet. It works now, although I still think the message is a bit confusing.

I’ll run a nixpkgs-review for the unit tests later. It’s a bit tricky to do right now since Torch just got upgraded and the cache is missing.

Update: about message #456908

@yzx9
Copy link
Contributor Author

yzx9 commented Oct 30, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 456471 --extra-nixpkgs-config '{ allowUnfree = true; cudaSupport = true; }' --package python3Packages.warp-lang.passthru.tests
Commit: bde133813053445a0485231aaf61354f3b18a6be

x86_64-linux

✅ 3 packages built:
  • python3Packages.warp-lang.passthru.tests.cpu
  • python3Packages.warp-lang.passthru.tests.cuda.cudaOnly
  • python3Packages.warp-lang.passthru.tests.cuda.cudaWithLibmathDx

@yzx9 yzx9 changed the title python3Packages.wrap-lang: 1.9.0 -> 1.9.1, fix build python3Packages.warp-lang: 1.9.0 -> 1.9.1, fix build Oct 31, 2025
@yzx9 yzx9 added the 6.topic: cuda Parallel computing platform and API label Oct 31, 2025
@yzx9
Copy link
Contributor Author

yzx9 commented Nov 2, 2025

I noticed that warp-lang v1.10.0 has been released. However, I still hope this PR can be merged and backported to 25.11 to fix the build issue during the ZHF period.
Since v1.10.0 announced the removal of the warp.sim module, it’s not suitable for backporting. I’ll open a new PR to bump the version instead.

@yzx9 yzx9 added the 0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign label Nov 3, 2025
@ConnorBaker
Copy link
Contributor

ConnorBaker commented Nov 3, 2025

Apologies for the delay getting this approved and merged! Thank you for maintaining this package, it's one of the few I use :)

@ConnorBaker ConnorBaker added this pull request to the merge queue Nov 3, 2025
Merged via the queue into NixOS:master with commit ab7fb10 Nov 3, 2025
35 of 37 checks passed
@github-project-automation github-project-automation bot moved this from New to ✅ Done in CUDA Team Nov 3, 2025
@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Nov 3, 2025
@yzx9 yzx9 deleted the warp-lang-1-9-1 branch November 4, 2025 02:30
@yzx9
Copy link
Contributor Author

yzx9 commented Nov 4, 2025

@ConnorBaker Thanks for the review! Great to see you’re care about CUDA support again.

@ConnorBaker
Copy link
Contributor

ConnorBaker commented Nov 4, 2025

Oh I’m still absolutely burnt out :)

@yzx9 yzx9 mentioned this pull request Nov 14, 2025
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ConnorBaker ConnorBaker ConnorBaker approved these changes

@natsukium natsukium Awaiting requested review from natsukium

Assignees

No one assigned

Labels

0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign 6.topic: cuda Parallel computing platform and API 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

CUDA Team
Status: ✅ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yzx9 @ConnorBaker